Skip to content

Remove hard-coded cert-manager configuration and improve TLS docs #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 16, 2025

Conversation

emmanuelmathot
Copy link
Contributor

Fixes #226

This PR removes the hard-coded cert-manager configuration from the Helm chart and updates the documentation with a comprehensive guide for setting up TLS with cert-manager.

Changes:

  1. Remove cert-manager annotations from ingress.yaml
  2. Simplify TLS configuration in values.yaml to only include essential fields
  3. Update unified-ingress.md documentation with:
    • Remove outdated cert-manager configuration
    • Add complete guide for setting up cert-manager with Let's Encrypt
    • Include examples for both staging and production environments
    • Show how to use ClusterIssuer for certificate management

Users can now fully control certificate management through their own annotations, with clear documentation on how to set it up using existing cluster resources.

@emmanuelmathot emmanuelmathot requested review from sunu and batpad May 14, 2025 08:01
Copy link
Member

@batpad batpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfct! And I've already tested that this works by adding a custom annotation and setting certManager to false so LGTM.

Copy link
Member

@sunu sunu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emmanuelmathot emmanuelmathot merged commit af5ab47 into main May 16, 2025
2 checks passed
@emmanuelmathot emmanuelmathot deleted the certissuer-fix branch May 16, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow using a ClusterIssuer on the cluster for TLS
3 participants