Skip to content

Feat/add GitHub actions#22

Open
matthew-petrie wants to merge 8 commits intodevetry:masterfrom
matthew-petrie:feat/add-github-actions
Open

Feat/add GitHub actions#22
matthew-petrie wants to merge 8 commits intodevetry:masterfrom
matthew-petrie:feat/add-github-actions

Conversation

@matthew-petrie
Copy link
Collaborator

@matthew-petrie matthew-petrie commented Mar 16, 2021

Runs npm test and npm lint concurrently on any PRs that are opened. Closes #21

@matthew-petrie matthew-petrie self-assigned this Mar 16, 2021
@matthew-petrie matthew-petrie marked this pull request as draft March 16, 2021 15:48
@matthew-petrie
Copy link
Collaborator Author

Github Actions ran in my fork of the repo but have not run on this PR... looking into it

@bgschiller
Copy link
Contributor

I think that's a security safeguard. If it works on your branch, i'd guess that it will work here once we merge it.
https://github.community/t/github-action-workflow-is-executed-for-a-pr-from-a-forked-repo-if-the-pr-changes-the-workflow-file/16059

@matthew-petrie
Copy link
Collaborator Author

@bgschiller ah, good spot! Seems you can enable the actions to run if the repo is private: https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/

I created another non-forked PR just now and it all worked so believe this PR is good to go.

@matthew-petrie matthew-petrie marked this pull request as ready for review March 20, 2021 10:43
@matthew-petrie
Copy link
Collaborator Author

@bgschiller not meaning to pester; if there is any chance of getting this merged down &/or the NPM module being upgraded that would be amazing (we had to temporarily take the module out due to the transactional bug (now fixed in this repo) and very keen to get it back in!)

Thanks

@matthew-petrie
Copy link
Collaborator Author

@bgschiller sorry to bother you again, just wondering if you might have time to release this (or the current master which has a bug fix) as a new version of the NPM module.

If you would like I am more than happy to help manage the NPM package etc. if that would save you some time.

Many thanks, Matthew

@bgschiller
Copy link
Contributor

Hi @matthew-petrie ,

Sorry this fell through the cracks. Let me make you a maintainer on the npm package and then you'll be able to do the release when I drop the ball.

What's your npmjs.org username?

@matthew-petrie matthew-petrie removed their assignment Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI/CD for PRs

2 participants