Conversation
|
Github Actions ran in my fork of the repo but have not run on this PR... looking into it |
|
I think that's a security safeguard. If it works on your branch, i'd guess that it will work here once we merge it. |
|
@bgschiller ah, good spot! Seems you can enable the actions to run if the repo is private: https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/ I created another non-forked PR just now and it all worked so believe this PR is good to go. |
|
@bgschiller not meaning to pester; if there is any chance of getting this merged down &/or the NPM module being upgraded that would be amazing (we had to temporarily take the module out due to the transactional bug (now fixed in this repo) and very keen to get it back in!) Thanks |
|
@bgschiller sorry to bother you again, just wondering if you might have time to release this (or the current master which has a bug fix) as a new version of the NPM module. If you would like I am more than happy to help manage the NPM package etc. if that would save you some time. Many thanks, Matthew |
|
Hi @matthew-petrie , Sorry this fell through the cracks. Let me make you a maintainer on the npm package and then you'll be able to do the release when I drop the ball. What's your npmjs.org username? |
Runs
npm testandnpm lintconcurrently on any PRs that are opened. Closes #21