Fix build for newer versions of time#4
Open
Daniel-Diaz wants to merge 2 commits intodeviant-logic:masterfrom
Open
Fix build for newer versions of time#4Daniel-Diaz wants to merge 2 commits intodeviant-logic:masterfrom
Daniel-Diaz wants to merge 2 commits intodeviant-logic:masterfrom
Conversation
added 2 commits
November 26, 2020 17:52
Merge with mainstream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple patch makes
aeson-filthycompatible with newer versions oftime, whereparseTimeMrequiresMonadFail, due to changes in the base library.Firstdoesn't have aMonadFailinstance, so I usedMaybe's instead. The same code should work for older versions oftimetoo.