fix: suppress browser launch in noui builds#812
Merged
rsdmike merged 3 commits intodevice-management-toolkit:mainfrom Feb 25, 2026
Merged
fix: suppress browser launch in noui builds#812rsdmike merged 3 commits intodevice-management-toolkit:mainfrom
rsdmike merged 3 commits intodevice-management-toolkit:mainfrom
Conversation
7ce4fa1 to
d81aa7c
Compare
sudhir-intc
approved these changes
Feb 24, 2026
rsdmike
approved these changes
Feb 25, 2026
auto-merge was automatically disabled
February 25, 2026 16:36
Rebase failed
rsdmike
added a commit
that referenced
this pull request
Feb 25, 2026
rsdmike
added a commit
that referenced
this pull request
Feb 25, 2026
|
🎉 This PR is included in version 1.21.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: noui builds launch a browser window on startup
When running the
console-nouibinary (built with-tags=noui), a browser window was being opened on startup. This is incorrect behavior — the noui build is intended for headless/server environments where there is no display or UI.Root cause
handleDebugModeincmd/app/main.gounconditionally calledgo launchBrowser(cfg)wheneverGIN_MODE != "debug", with no awareness of thenouibuild tag.Fix
Split the browser-launch code into build-tagged files:
browser.go!nouilaunchBrowser,openBrowser,CommandExecutorbrowser_noui.gonouilaunchBrowserthat does nothingbrowser_test.go!nouimain_test.goto exclude from noui test buildsmain.go/main_test.goTesting
Both build variants compile and all tests pass: