Fix Apple Pencil compatibility for M4 iPad Pro and M2/M3 iPad Air models #474

Copilot · 2025-11-17T21:11:12Z

Fix incorrect Apple Pencil compatibility for recent iPad models

Based on Apple's official documentation at https://support.apple.com/en-au/HT211029:

Changes Summary:

✅ iPad (10th gen) & iPad (A16)

Before: Apple Pencil (USB-C) only
After: Apple Pencil (1st gen) + Apple Pencil (USB-C)

✅ iPad Air 11" & 13" (M2)

Before: Apple Pencil (2nd gen) + Apple Pencil Pro
After: Apple Pencil (USB-C) + Apple Pencil Pro

✅ iPad Air 11" & 13" (M3)

Before: Apple Pencil (2nd gen) + Apple Pencil Pro
After: Apple Pencil (USB-C) + Apple Pencil Pro

✅ iPad Pro 11" & 13" (M4)

Before: Apple Pencil (2nd gen) + Apple Pencil (USB-C) + Apple Pencil Pro
After: Apple Pencil (USB-C) + Apple Pencil Pro

Technical Changes:

Files Changed:

Source/Device.swift.gyb - Updated device definitions and added template case for value 13
Source/Device.generated.swift - Regenerated from template without sourceLocation lines (1235 debug lines removed)
Tests/Tests.swift - Added 50 lines of tests validating all changes

Note: This project requires macOS with Xcode to build and test. The CI pipeline will validate these changes on macOS.

Original prompt

This section details on the original issue you should resolve

<issue_title>Incorrect Apple Pencil compatibility for M4 iPad Pro and M2/M3 iPad Air models</issue_title>
<issue_description>Device.applePencilSupport currently lists incorrect Apple Pencil compatibility for several recent iPad models.
Apple’s official documentation: https://support.apple.com/en-au/HT211029

M4 iPad Pro (11/13") – Does not support Apple Pencil (2nd gen). Supports Pencil Pro and Pencil (USB-C).

iPad Air (M2/M3, 11" & 13") – Supports Pencil Pro and Pencil (USB-C), not 2nd gen.

iPad (10th gen) & iPad (A16) – Supports Pencil (USB-C) and Pencil (1st gen).

Proposed fix:
case .iPadPro11M4, .iPadPro13M4:
    return [.firstGenerationUsbC, .pro]

case .iPadAir11M2, .iPadAir13M2, .iPadAir11M3, .iPadAir13M3:
    return [.firstGenerationUsbC, .pro]

case .iPad10, .iPadA16:
    return [.firstGenerationUsbC, .firstGeneration]
</issue_description>

## Comments on the Issue (you are @copilot in this section)

<comments>
</comments>

Fixes Incorrect Apple Pencil compatibility for M4 iPad Pro and M2/M3 iPad Air models #460

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>

github-actions · 2025-11-17T21:19:49Z

	15 Warnings
⚠️	Plist changed, don't forget to localize your plist values
⚠️	Source/Device.generated.swift#L742 - TODOs should be resolved (Replace with proper implementa…). `todo` `Device.generated.swift:742`
⚠️	Source/Device.generated.swift#L1319 - TODOs should be resolved (Replace with proper implementa…). `todo` `Device.generated.swift:1319`
⚠️	Source/Device.generated.swift#L1583 - TODOs should be resolved (Replace with proper implementa…). `todo` `Device.generated.swift:1583`
⚠️	Source/Device.generated.swift#L1761 - TODOs should be resolved (Replace with proper implementa…). `todo` `Device.generated.swift:1761`
⚠️	Source/Device.generated.swift#L1919 - TODOs should be resolved (Replace with proper implementa…). `todo` `Device.generated.swift:1919`
⚠️	Source/Device.generated.swift#L2623 - TODOs should be resolved (Replace with proper implementa…). `todo` `Device.generated.swift:2623`
⚠️	Source/Device.generated.swift#L2684 - TODOs should be resolved (Replace with proper implementa…). `todo` `Device.generated.swift:2684`
⚠️	Tests/Tests.swift#L463 - Collection literals should not have trailing commas. `trailing_comma` `Tests.swift:463`
⚠️	Tests/Tests.swift#L496 - Collection literals should not have trailing commas. `trailing_comma` `Tests.swift:496`
⚠️	Tests/Tests.swift#L531 - Collection literals should not have trailing commas. `trailing_comma` `Tests.swift:531`
⚠️	Tests/Tests.swift#L538 - Function body should span 40 lines or less excluding comments and whitespace: currently spans 44 lines `function_body_length` `Tests.swift:538`
⚠️	Tests/Tests.swift#L580 - Collection literals should not have trailing commas. `trailing_comma` `Tests.swift:580`
⚠️	Tests/Tests.swift#L668 - Collection literals should not have trailing commas. `trailing_comma` `Tests.swift:668`
⚠️	Tests/Tests.swift#L709 - Collection literals should not have trailing commas. `trailing_comma` `Tests.swift:709`

SwiftLint found issues

Warnings

File	Line	Reason
Tests.swift	538	Function body should span 40 lines or less excluding comments and whitespace: currently spans 44 lines (function_body_length)
Tests.swift	463	Collection literals should not have trailing commas. (trailing_comma)
Tests.swift	496	Collection literals should not have trailing commas. (trailing_comma)
Tests.swift	531	Collection literals should not have trailing commas. (trailing_comma)
Tests.swift	580	Collection literals should not have trailing commas. (trailing_comma)
Tests.swift	668	Collection literals should not have trailing commas. (trailing_comma)
Tests.swift	709	Collection literals should not have trailing commas. (trailing_comma)
Tests.swift	722	Lines should not have trailing whitespace. (trailing_whitespace)
Tests.swift	728	Lines should not have trailing whitespace. (trailing_whitespace)
Tests.swift	734	Lines should not have trailing whitespace. (trailing_whitespace)
Tests.swift	740	Lines should not have trailing whitespace. (trailing_whitespace)
Tests.swift	746	Lines should not have trailing whitespace. (trailing_whitespace)
Tests.swift	752	Lines should not have trailing whitespace. (trailing_whitespace)
Tests.swift	758	Lines should not have trailing whitespace. (trailing_whitespace)
Device.generated.swift	742	TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift	1319	TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift	1583	TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift	1761	TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift	1919	TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift	2623	TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift	2684	TODOs should be resolved (Replace with proper implementa...). (todo)

Generated by 🚫 Danger

Zandor300 · 2025-11-17T21:22:55Z

@copilot remove sourceLocation lines from generated Swift file.

Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>

Copilot · 2025-11-17T21:30:40Z

@copilot remove sourceLocation lines from generated Swift file.

Done! Regenerated the file using gyb.py --line-directive '' to suppress the sourceLocation debug markers. All 1235 lines removed while preserving the Apple Pencil compatibility fixes. (774cb6c)

github-actions · 2025-11-17T21:32:31Z

Tests/Tests.swift

+    XCTAssertTrue(Device.iPad10.applePencilSupport.contains(.firstGenerationUsbC))
+    XCTAssertFalse(Device.iPad10.applePencilSupport.contains(.secondGeneration))
+    XCTAssertFalse(Device.iPad10.applePencilSupport.contains(.pro))
+


⚠️ Lines should not have trailing whitespace.
trailing_whitespace Tests.swift:722

github-actions · 2025-11-17T21:32:31Z

Tests/Tests.swift

+    XCTAssertTrue(Device.iPadA16.applePencilSupport.contains(.firstGenerationUsbC))
+    XCTAssertFalse(Device.iPadA16.applePencilSupport.contains(.secondGeneration))
+    XCTAssertFalse(Device.iPadA16.applePencilSupport.contains(.pro))
+


⚠️ Lines should not have trailing whitespace.
trailing_whitespace Tests.swift:728

github-actions · 2025-11-17T21:32:32Z

Tests/Tests.swift

+    XCTAssertTrue(Device.iPadAir11M2.applePencilSupport.contains(.firstGenerationUsbC))
+    XCTAssertFalse(Device.iPadAir11M2.applePencilSupport.contains(.secondGeneration))
+    XCTAssertTrue(Device.iPadAir11M2.applePencilSupport.contains(.pro))
+


⚠️ Lines should not have trailing whitespace.
trailing_whitespace Tests.swift:734

github-actions · 2025-11-17T21:32:33Z

Tests/Tests.swift

+    XCTAssertTrue(Device.iPadAir13M2.applePencilSupport.contains(.firstGenerationUsbC))
+    XCTAssertFalse(Device.iPadAir13M2.applePencilSupport.contains(.secondGeneration))
+    XCTAssertTrue(Device.iPadAir13M2.applePencilSupport.contains(.pro))
+


⚠️ Lines should not have trailing whitespace.
trailing_whitespace Tests.swift:740

github-actions · 2025-11-17T21:32:33Z

Tests/Tests.swift

+    XCTAssertTrue(Device.iPadAir11M3.applePencilSupport.contains(.firstGenerationUsbC))
+    XCTAssertFalse(Device.iPadAir11M3.applePencilSupport.contains(.secondGeneration))
+    XCTAssertTrue(Device.iPadAir11M3.applePencilSupport.contains(.pro))
+


⚠️ Lines should not have trailing whitespace.
trailing_whitespace Tests.swift:746

github-actions · 2025-11-17T21:32:34Z

Tests/Tests.swift

+    XCTAssertTrue(Device.iPadAir13M3.applePencilSupport.contains(.firstGenerationUsbC))
+    XCTAssertFalse(Device.iPadAir13M3.applePencilSupport.contains(.secondGeneration))
+    XCTAssertTrue(Device.iPadAir13M3.applePencilSupport.contains(.pro))
+


⚠️ Lines should not have trailing whitespace.
trailing_whitespace Tests.swift:752

github-actions · 2025-11-17T21:32:35Z

Tests/Tests.swift

+    XCTAssertTrue(Device.iPadPro11M4.applePencilSupport.contains(.firstGenerationUsbC))
+    XCTAssertFalse(Device.iPadPro11M4.applePencilSupport.contains(.secondGeneration))
+    XCTAssertTrue(Device.iPadPro11M4.applePencilSupport.contains(.pro))
+


⚠️ Lines should not have trailing whitespace.
trailing_whitespace Tests.swift:758

Initial plan

cc4cf2c

Copilot AI assigned Copilot and Zandor300 Nov 17, 2025

Copilot started work on behalf of Zandor300 November 17, 2025 21:11 View session

Copilot AI and others added 2 commits November 17, 2025 21:16

Fix Apple Pencil compatibility for iPad models

97c6afd

Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>

Add tests for Apple Pencil compatibility

b6fd600

Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix incorrect Apple Pencil compatibility for iPad models~~ Fix Apple Pencil compatibility for M4 iPad Pro and M2/M3 iPad Air models Nov 17, 2025

Copilot AI requested a review from Zandor300 November 17, 2025 21:27

Copilot finished work on behalf of Zandor300 November 17, 2025 21:27

Copilot started work on behalf of Zandor300 November 17, 2025 21:28 View session

Remove sourceLocation lines from generated Swift file

774cb6c

Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>

Copilot finished work on behalf of Zandor300 November 17, 2025 21:32

github-actions bot reviewed Nov 17, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix Apple Pencil compatibility for M4 iPad Pro and M2/M3 iPad Air models #474

Fix Apple Pencil compatibility for M4 iPad Pro and M2/M3 iPad Air models #474

Uh oh!

Copilot AI commented Nov 17, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 17, 2025 •

edited

Loading

Uh oh!

Zandor300 commented Nov 17, 2025

Uh oh!

Copilot AI commented Nov 17, 2025

Uh oh!

github-actions bot Nov 17, 2025

Uh oh!

github-actions bot Nov 17, 2025

Uh oh!

github-actions bot Nov 17, 2025

Uh oh!

github-actions bot Nov 17, 2025

Uh oh!

github-actions bot Nov 17, 2025

Uh oh!

github-actions bot Nov 17, 2025

Uh oh!

github-actions bot Nov 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix Apple Pencil compatibility for M4 iPad Pro and M2/M3 iPad Air models #474

Are you sure you want to change the base?

Fix Apple Pencil compatibility for M4 iPad Pro and M2/M3 iPad Air models #474

Uh oh!

Conversation

Copilot AI commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SwiftLint found issues

Warnings

Uh oh!

Zandor300 commented Nov 17, 2025

Uh oh!

Copilot AI commented Nov 17, 2025

Uh oh!

github-actions bot Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Nov 17, 2025 •

edited

Loading

github-actions bot commented Nov 17, 2025 •

edited

Loading