-
Notifications
You must be signed in to change notification settings - Fork 2.4k
update icon: nginx (original, original-wordmark, plain) #2291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
[why] The aspect ratio of the previous nginx logo made it very hard to read/identify on terminals, this new icon have a better aspect ratio making it identifiable. [how] Rename previous icon as wormark, add new original icon and its plain version to make it suitable for fonts, specifically Nerd Fonts.
[why] Plain icon is missing but would be better than the wordmark icon. [how] Add plain icon, taken from their website. [note] Similar (but slightly different svg) to devicons/devicon#2291 Suggested-by: hasecilu Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] Plain icon is missing but would be better than the wordmark icon. [how] Add plain icon, taken from their website. [note] Similar (but slightly different svg) to devicons/devicon#2291 Suggested-by: hasecilu Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
|
Hi! I'm the Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
Snailedlt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the most part.
I changed the name of the wordmark to align with our naming conventions.
I also checked the official website to see if there were any official icons, but all of the ones I could find were either raster images, or included text in them. I did however see that the colors used on the official logos are slightly different from the ones you have.
There are two main colors being used on the nginx official website. These colors being: #009639 and #009828, of which the first is more prevalent... So I suggest we change the color to that.
Other than that, very good job!
|
Hi! I'm the Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
|
Hi! I'm the Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
|
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
|
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
Snailedlt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.


















Double check these details before you open a PR
Features
[why]
The aspect ratio of the previous nginx logo made it very hard to read/identify on terminals, this new icon have a better aspect ratio making it identifiable.
[how]
Rename previous icon as wormark, add new original icon and its plain version to make it suitable for fonts, specifically Nerd Fonts.
This PR closes NONE
Notes
Ideally the new icon will be use for the next Nerd Fonts version.