-
Notifications
You must be signed in to change notification settings - Fork 2.4k
new icon: typer (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #2590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
@weh Can you tag it with Hacktoberfest? |
weh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Bulani, thank you for your contribution. To use the icon for the font, it needs to be a single svg path with a single color. so in the current form it is not usable. Check our wiki pages for instructions: Creating Plain Icons
Also the current file should be named typer-original-wordmark.svg. If you find time it should be no big effort to also create a typer-original.svg and typer-plain.svg version by removing the text. This should not be a big thing, and would match most of the existing icon submissions having versions with and without wordmark.
|
@Bulani, do you need help or have questions about the needed changes? |
|
@Bulani, i can make the changes myself, but just to be clear, this is not in the spirit of hacktoberfest. |
weh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the open request and added some more versions
|
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |














Double check these details before you open a PR
developbranch.devicon.jsonfile at the correct alphabetic position as seen hereThis PR closes #2562
Link to prove your SVG is correct and up-to-date.
https://typer.tiangolo.com/
https://github.com/fastapi/typer/blob/master/docs/img/icon.svg