Skip to content

fix: prevent path traversal via crafted session token in FileTokenStore #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devld merged 1 commit into from
Mar 30, 2026
Merged

fix: prevent path traversal via crafted session token in FileTokenStore #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion server/file_token.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,13 @@ func (f *FileTokenStore) Revoke(token string) error {
}

func (f *FileTokenStore) getSessionFile(token string) string {
return filepath.Join(f.root, filepath.Clean(sessionPrefix+token))
// Sanitize token to prevent path traversal — only allow UUID characters
for _, c := range token {
if !((c >= 'a' && c <= 'f') || (c >= '0' && c <= '9') || c == '-') {
return filepath.Join(f.root, sessionPrefix+"invalid")
}
}
return filepath.Join(f.root, sessionPrefix+token)
}

func (f *FileTokenStore) readFile(token string, read bool) (*types.Token, error) {
Expand Down
Loading