Refactor Kakapo to not be json centric WIP #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a draft PR to address #153, I want some feedback before proceeding with updating the documentation, README, tests The idea is that Router now doesn’t work anymore w/ `Serializable` objects and `ResponseFieldsProvider` is not anymore a special `Serializable`. Router now only accept `ResponseFieldsProvider`s an object that provides: statusCode (Int) headerfields (dict) body (data) `Serializable` became a `ResponseFieldsProvider` that by default has a status code == 200 and “Content-Type” == “application/json”. It should have been like that since ever, so we can use Kakapo with images, xml or whatever we want by creating new `ResponseFieldsProvider ` The change is a breaking change but not a big one for users of Kakapo (only objects that were confirming to ResponseFieldsProvider will be broken)
Member
Author
|
@zzarcon might be interesting also for Kakapo.js 🤷♂️ |
Generated by 🚫 Danger |
|
+1 for this cos we need to use this to mock binary protobuf response. any updates? |
Member
|
@MP0w can you give us an update on this? is the project dead? 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR to address #153, I want some feedback before proceeding with updating the documentation, README, tests
The idea is that Router now doesn’t work anymore w/
Serializableobjects andResponseFieldsProvideris not anymore a specialSerializable.Router now only accept
ResponseFieldsProviders an object that provides:statusCode (Int)
headerfields (dict)
body (data)
Serializablebecame aResponseFieldsProviderthat by default has a status code == 200 and “Content-Type” == “application/json”.It should have been like that since ever, so we can use Kakapo with images, xml or whatever we want by creating new
ResponseFieldsProviderThe change is a breaking change but not a big one for users of Kakapo (only objects that were confirming to ResponseFieldsProvider will be broken)