resolved exervises - js-dom-elements#148
Open
marrcelp wants to merge 6 commits intodevmentor-pl:masterfrom
Open
resolved exervises - js-dom-elements#148marrcelp wants to merge 6 commits intodevmentor-pl:masterfrom
marrcelp wants to merge 6 commits intodevmentor-pl:masterfrom
Conversation
devmentor-pl
approved these changes
Dec 20, 2024
Owner
devmentor-pl
left a comment
devmentor-pl
left a comment
There was a problem hiding this comment.
Marcelu,
Tutaj wszystko ok 👍 , z jedną drobną uwagą - szczegóły w komentarzu.
|
|
||
| } else { | ||
| console.log(`Nie znaleziono elementu o podanej klasie`); | ||
| } |
| linksWithUrl.forEach((element) => { | ||
| const elementUrl = element.getAttribute('data-url'); | ||
| element.setAttribute('href', elementUrl) | ||
| }) No newline at end of file |
| newButton.textContent = buttonSettings.text; | ||
|
|
||
| const element = document.querySelector('.parent-for-button'); | ||
| element.appendChild(newButton); No newline at end of file |
| aElement.setAttribute('href', el.url) | ||
| navElement.appendChild(liElement); | ||
| liElement.appendChild(aElement); | ||
| })) No newline at end of file |
05/app.js
Outdated
Comment on lines
+12
to
+13
| const currSiblings = Array.from(currParent.children); | ||
| currSiblings.forEach(el => el.classList.add('siblings')); |
Owner
There was a problem hiding this comment.
Powinieneś wykluczyć element curr - on sam dla siebie nie jest rodzeństwem :)
devmentor-pl
approved these changes
Jan 6, 2025
| // 2 | ||
| const currSiblings = Array.from(currParent.children); | ||
| currSiblings.forEach(el => el.classList.add('siblings')); | ||
| currSiblings.filter((el) => !el.classList.contains('js-curr')).forEach(el => el.classList.add('siblings')); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.