practice-js-dom-elements#150
Open
bartoszdudziak-dev wants to merge 6 commits intodevmentor-pl:masterfrom
Open
Conversation
devmentor-pl
approved these changes
Dec 24, 2024
Owner
devmentor-pl
left a comment
devmentor-pl
left a comment
There was a problem hiding this comment.
Bartku,
Zostawiłem Ci parę drobnych uwag - poza tym ok 👍
| const elementsInfoList = element.querySelectorAll(`*[data-info]`); | ||
|
|
||
| console.log(`Found: ${elementsInfoList.length} elements`); | ||
| } |
02/app.js
Outdated
|
|
||
| const linksList = document.querySelectorAll("a[data-url]"); | ||
|
|
||
| if (linksList) { |
Owner
There was a problem hiding this comment.
Tutaj if jest niepotrzebny bo querySelectorAll zwraca obiekt "tablicopodobny", co powoduje, że to zawsze będzie prawda - obojętnie czy zostały odnalezione elementy czy nie. Jak już bardzo chcemy użyć if-a to tak: if(linksList.length > 0)
03/app.js
Outdated
Comment on lines
+17
to
+18
| button.classList.add(buttonSettings.attr.className); | ||
| button.setAttribute("title", buttonSettings.attr.title); |
Owner
There was a problem hiding this comment.
W przypadku attr też można użyć pętli -> button[key] = value
| }); | ||
|
|
||
| const navigationElement = document.querySelector("nav"); | ||
| if (navigationElement) navigationElement.appendChild(menuElement); |
05/app.js
Outdated
|
|
||
| // 2 | ||
| Array.from(curr.parentElement.children).forEach((child) => | ||
| child.classList.add("siblings") |
Owner
There was a problem hiding this comment.
Zwróć uwagę, że curr sam dla siebie nie jest "rodzeństwem" dlatego powinien zostać wykluczony z dodawania do niego klasy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.