Skip to content

Complete all tasks.#158

Open
MstowskaSandra wants to merge 7 commits intodevmentor-pl:masterfrom
MstowskaSandra:master
Open

Complete all tasks.#158
MstowskaSandra wants to merge 7 commits intodevmentor-pl:masterfrom
MstowskaSandra:master

Conversation

@MstowskaSandra
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown
Owner

@devmentor-pl devmentor-pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sandro,

Zadanka są ok! 👍
Zostawiłem jedną drobną uwagę :)

if(elementList !== null) {
const elementWithAttribute = elementList.querySelectorAll('[data-info]');
console.log("Liczba pasujących elementów:", elementWithAttribute.length);
};
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


const linkList = document.querySelectorAll('[data-url]');

if(linkList !== null) {
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TUtaj to nie zadziała, querySelectorAll zwraca tablicę (pustą lub wypełnioną), więc jak chcemy mieć if to w takiej postaci -> if(linkList.length > 0)

console.log(btn);

const buttonParent = document.querySelector('.parent-for-button');
buttonParent.appendChild(btn); No newline at end of file
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


const nav = document.querySelector('nav');
nav.appendChild(ul);
console.log(ul);
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

const section = parent.parentElement;
section.insertBefore(cloneArticle, section.firstElementChild);

console.log(section);
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants