Skip to content

Tasks Done#162

Open
TetraMeister wants to merge 1 commit intodevmentor-pl:masterfrom
TetraMeister:master
Open

Tasks Done#162
TetraMeister wants to merge 1 commit intodevmentor-pl:masterfrom
TetraMeister:master

Conversation

@TetraMeister
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown
Owner

@devmentor-pl devmentor-pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Łukaszu,

Jest ok 👍

if (element) {
const count1 = element.querySelectorAll('[data-info]').length;
console.log(count1)
};
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


aList.forEach(element => {
element.setAttribute('href', element.dataset.url);
}); No newline at end of file
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +25 to +29
if (key === "className") {
newBtn.className = buttonSettings.attr.className;
} else {
newBtn.setAttribute(key, buttonSettings.attr[key]);
}
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Można też tak: newBtn[key] = buttonSettings.attr[key] - bez if :)

menu2.appendChild(li).appendChild(a);
});

nav.appendChild(menu2); No newline at end of file
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


function createArticle(title = "Default Title") {

const articleStructure = {
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chyba łatwiej by było użyć .cloneNode :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants