Skip to content

Task: HTML and CSS basics #179

Open
Katalia91 wants to merge 10 commits intodevmentor-pl:masterfrom
Katalia91:master
Open

Task: HTML and CSS basics #179
Katalia91 wants to merge 10 commits intodevmentor-pl:masterfrom
Katalia91:master

Conversation

@Katalia91
Copy link
Copy Markdown

@Katalia91 Katalia91 commented Apr 1, 2025

Recreated the landing page.
Note: I changed the font-color for buttons to comply with WCAG guidelines.

Monosnap screencast 2025-04-01 21-03-51

devmentor-pl
devmentor-pl approved these changes Apr 2, 2025
View reviewed changes
Copy link
Copy Markdown
Owner

@devmentor-pl devmentor-pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Natalio,

Całość prezentuje się bardzo dobrze!
Zostawiłem parę drobnych uwag :)

@Katalia91
Copy link
Copy Markdown
Author

Katalia91 commented Apr 3, 2025

Dzięki!
Poprawiłam, znalazłam więcej podobnych przypadków i zagnieżdżeń i je też poprawiłam. Mam chyba dalej problem z rozróżnieniem kiedy mam użyć bloku, a kiedy elementu. Np. w tym przypadku chyba bardziej naturalne byłoby dodanie elementu card__image zamiast card-image? Ewentualnie mogłabym jeszcze mieć card__image image jeśli chciałabym mieć niezależny element image.

        <li class="card">
          <figure class="card-image">
            <img src="images/responsive.svg" alt="" />
          </figure>
          <div class="card-content">
            <h3 class="card-content__title title">Fully responsive</h3>
            <p>
              Looks amazing on any device: smartphone, tablet, laptop and
              desktop.
            </p>
          </div>
        </li>

devmentor-pl
devmentor-pl approved these changes Apr 7, 2025
View reviewed changes
Copy link
Copy Markdown
Owner

@devmentor-pl devmentor-pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Natalio,

Super, o to chodziło! 👍

index.html
</div>
<div class="container container--hero">
<article class="content">
<article class="content hero__content">
Copy link
Copy Markdown
Owner

@devmentor-pl devmentor-pl Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

index.html
</header>
<section class="features">
<div class="container container--title">
<header class="container container--title">
Copy link
Copy Markdown
Owner

@devmentor-pl devmentor-pl Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

index.html
<h2>Simple and beautiful</h2>
<p>
<h2 class="text__title">Simple and beautiful</h2>
<p class="text__content">
Copy link
Copy Markdown
Owner

@devmentor-pl devmentor-pl Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

index.html
<li class="card card--featured">
<div class="plan-price">
<h3>Basic</h3>
<h3 class="plan-price__title title">Basic</h3>
Copy link
Copy Markdown
Owner

@devmentor-pl devmentor-pl Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Katalia91
Copy link
Copy Markdown
Author

Katalia91 commented Apr 7, 2025

@devmentor-pl Poprawiłam - już ostatni raz, bo zauważyłam, że zapomniałam dodać modyfikatora do reszty kart card--team. Zostawiłam też dwa pytania w komentarzach.

devmentor-pl
devmentor-pl approved these changes Apr 8, 2025
View reviewed changes
Copy link
Copy Markdown
Owner

@devmentor-pl devmentor-pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Natalio,

Zmiany są zdecydowanie na plus ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devmentor-pl devmentor-pl devmentor-pl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Katalia91 @devmentor-pl