Skip to content

Task: HTML and CSS basics#180

Open
satoshi300 wants to merge 12 commits intodevmentor-pl:masterfrom
satoshi300:master
Open

Task: HTML and CSS basics#180
satoshi300 wants to merge 12 commits intodevmentor-pl:masterfrom
satoshi300:master

Conversation

@satoshi300
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Owner

@devmentor-pl devmentor-pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Michale,

Świetnie sobie poradziłeś! - gratuluję! 👍 🥇
Zostawiłem parę drobnych uwag w komentarzach :)

<section class="header__image cell">

<figure class="header__image-style">
<img
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ten img niepotrzebnie "prześwituje" - wystarczy nadać "background" dla img na "biało" i będzie ok :)

index.html Outdated

<body>
<header class="header row">
<div class="header__container container">
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Można zamiast div użyć section

index.html Outdated
</ul>
</nav>
</div>
<div class="header__container header__container-bottom container">
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tutaj również może być section

index.html Outdated
Comment on lines +73 to +74
<div class="features__main container">
<div class="feature__item feature__item-left cell">
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TUtaj bym zrobił ul > li bo mamy listę elementów, gdzie li to .feature__item

index.html Outdated
</p>
</header>
<section class="pricing__items container">
<div class="pricing__item pricing__item-sides cell">
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tutaj nawet zamiast div można dać article, bo każdy pakiet cenowy to jedna spójna treść.

Copy link
Copy Markdown
Owner

@devmentor-pl devmentor-pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Michale,

Super, o to chodziło! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants