Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
215 changes: 215 additions & 0 deletions index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,215 @@
<!DOCTYPE html>
<html lang="pl">

<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Zadanie 5</title>
<link rel="stylesheet" href="./styles/base.css">
<link rel="stylesheet" href="./styles/header.css">
<link rel="stylesheet" href="./styles/content.css">
<link rel="stylesheet" href="./styles/footer.css">
</head>

<body>

<!-- Pytanie czy w VSC moge tworzyć własne szablony i donieśc się do nich jak w Emmet? -->
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W zadaniach podrzuciłem Ci link ;)


<!-- Header start -->

<header class="header row">
<div class="header__container container">
<h1 class="header__logo cell">
<a href="#"><img src="images/logo.svg" alt=""></a>
</h1>
<nav class="header__nav cell">
<ul>
<li><a href="#">Team</a></li>
<li><a href="#">Pricing</a></li>
<li><a href="#">Features</a></li>
</ul>
</nav>
</div>
</header>

<!-- Slider -->

<section data-id="Slider" class="content row">
<div class="content__container container">
<article class="content__article cell left">
<title>Beautiful Free Nova template</title>
<p>A top notch premium quality template for your next web project.</p>
<button type="button">Download FREE!</button>
</article>
<article class="content__article cell right">
Comment on lines +43 to +44
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Na pewno nie robiłbym 2 razy article. Bo ten tag dla samego img to za mało.
Zrobiłbym odwrotnie tj. div zamieniłbym na article, a div dodał do treści artykułu, aby móc go wypozycjonować. Natomiast zamiast okalać img przez article, to zrobiłbym figure.

PS. Tak title jest wykorzystywany jedynie w head. Tutaj powinno być h1 lub inny poziom

<a href="#"><img class="screen" src="images/screen.png" alt=""></a>
</article>
</div>
</section>

<!-- Features -->

<section data-id="Features" class="content row">
<div class="content__container container">
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mozna zamiast div użyć header jako nagłówek dla sekcji

<article class="content__article title--module">FEATURES</article>
</div>
<div class="content__container container">
<article class="content__article cell">
Comment on lines +56 to +57
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Osobiście zrobiłbym ul > li zamiast div > article, mamy listę cech więc lepiej się mi to komponuje.

<div>
<img src="images/responsive.svg" alt="">
</div>
<title>fully responsive</title>
<p>Look amazing on any device: smartphone, tablet, laptop and desktop</p>
</article>
<article class="content__article cell">
<div>
<img src="images/customizable.svg" alt="">
</div>
<title>customizable</title>
<p>Look amazing on any device: smartphone, tablet, laptop and desktop</p>
</article>
<article class="content__article cell">
<div>
<img src="images/design.svg" alt="">
</div>
<title>slick and beautiful design</title>
<p>Look amazing on any device: smartphone, tablet, laptop and desktop</p>
</article>
</div>
</section>

<!-- Module cooperating companies -->

<section data-id="Module cooperating" class="content row">

<article class="content__article cell">
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zdecydowanie to nie article - mam wrażenie, że jak kiedyś się nadużywało div to ty teraz to wszystkiego starasz się użyć article. TO nie jest dobre rozwiązanie. Tutaj zdecydowanie lepioej będzie pasować aside.

<a href="#"><img src="images/logos.png" alt=""></a>
</article>
</section>

<!-- Simple -->

<section data-id="Simple" class="content row">

<article class="content__article cell left">
<a href="#"><img src="images/imac.png" alt=""></a>
</article>
<article class="content__article cell right">
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tutaj article ok.

<div>
<title>simple and beautiful</title>
<p>Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the
industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type
and scrambled it to make a type specimen book.</p>
</div>
</article>

</section>

<!-- Pricing plan -->

<section data-id="Pricing plan" class="content row">
<div class="content__container container">
<article class="content__article title--module">
Comment on lines +111 to +112
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Użyłbym zamiast div oraz article to tylko header

<title> choose your pricing plan</title>
<span>Pick any of our super affordable pricing plans</span>
</article>
</div>
<div class="content__container container">
<article class="content__article cell">
<div>
<title>basic</title>
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ponownie zwracam uwagę, że tutaj raczej np. h2 lub h3

<span>$15</span>
<p>per mouth</p>
<ul>
<li>Up to 7 Projects</li>
<li>2 Additional Developers</li>
</ul>
</div>
<button>Get Started</button>
</article>
<article class="content__article cell">
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TUtaj article jest ok

<div>
<title>agency</title>
<span>$55</span>
<p>per mouth</p>
<ul>
<li>Up to 7 Projects</li>
<li>2 Additional Developers</li>
<li>Unlimited Support</li>
</ul>

</div>
<button>Get Started</button>
</article>

<article class="content__article cell">
<div>
<title>pro</title>
<span>$75</span>
<p>per mouth</p>
<ul>
<li>Up to 7 Projects</li>
<li>2 Additional Developers</li>
<li>Unlimited Support</li>
<li>1.5GB Disk Space</li>
</ul>
</div>
<button>Get Started</button>
</article>
</div>
</section>

<!-- The team -->

<section data-id="The team" class="content row">
<div class="content__container container">
<article class="content__article title--module">THE TEAM</article>
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zdecydowanie nie article, można użyć h3.

</div>
<div class="content__container container">
<article class="content__article cell">
Comment on lines +168 to +169
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tutaj mamy listę członków zespołu więc ponownie zrobiłbym ul > li zamiast div > article

<div>
<img class="person" src="images/cto.png" alt="">
<title>CEO</title>
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jak wcześniej :)

<p class="name">jonny b good</p>
<p class="about">The brains behind the whole operation</p>
<span><img src="images/twitter.svg" alt=""><img src="images/facebook.svg" alt=""></span>
</div>
</article>
<article class="content__article cell">
<div>
<img class="person" src="images/ceo.png" alt="">
<title>CEO</title>
<p class="name">roll over beethoven</p>
<p class="about">TThe one the puts it all toghether</p>
<span><img src="images/twitter.svg" alt=""><img src="images/facebook.svg" alt=""></span>
</div>
</article>
<article class="content__article cell">
<div>
<img class="person" src="images/cfo.png" alt="">
<title>CEO</title>
<p class="name">chuck barry</p>
<p class="about">The guy with his hand on the wallet</p>
<span><img src="images/twitter.svg" alt=""><img src="images/facebook.svg" alt=""></span>
</div>
</article>
</div>
</section>

<!-- Module 6 -->

<!-- Footer start -->

<footer class="footer row">
<div class="footer__container container">
<section class="footer__logo cell">
<span>A free template by</span><img src="images/webscope.svg">
</section>
</div>
</footer>

<!-- Footer end -->

</body>

</html>
34 changes: 34 additions & 0 deletions styles/base.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
/* base.css */
body{
margin: 0px;
}

.row,
.cell,
.container {
box-sizing: border-box;
margin: 0px;
padding: 0px;
}

.row {
margin-bottom: 0px;
padding: 12px 0px;
}

.container {
margin: 0 auto;
max-width: 1150px;
}

.cell {
min-height: 50px;
}

title{
display: block;
}

button{
cursor: pointer;
}
Loading