Skip to content

Update the sdp field in the RTCIceCandidate class to candidate #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
970263611 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update the sdp field in the RTCIceCandidate class to candidate #227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions webrtc/src/main/java/dev/onvoid/webrtc/RTCIceCandidate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ public class RTCIceCandidate {
public final int sdpMLineIndex;

/**
* SDP string representation of this candidate.
* Candidate string representation of this candidate.
*/
public final String sdp;
public final String candidate;

/**
* The URL of the ICE server which this candidate was gathered from.
Expand All @@ -52,11 +52,11 @@ public class RTCIceCandidate {
*
* @param sdpMid The media stream "identification-tag"
* @param sdpMLineIndex The index (starting at zero) of the media
* description in the SDP.
* @param sdp SDP string representation of the candidate.
* description in the Candidate.
* @param candidate Candidate string representation of the candidate.
*/
public RTCIceCandidate(String sdpMid, int sdpMLineIndex, String sdp) {
this(sdpMid, sdpMLineIndex, sdp, null);
public RTCIceCandidate(String sdpMid, int sdpMLineIndex, String candidate) {
this(sdpMid, sdpMLineIndex, candidate, null);
}

/**
Expand All @@ -65,21 +65,21 @@ public RTCIceCandidate(String sdpMid, int sdpMLineIndex, String sdp) {
* @param sdpMid The media stream "identification-tag"
* @param sdpMLineIndex The index (starting at zero) of the media
* description in the SDP.
* @param sdp SDP string representation of the candidate.
* @param candidate Candidate string representation of the candidate.
* @param serverUrl The URL of the ICE server.
*/
public RTCIceCandidate(String sdpMid, int sdpMLineIndex, String sdp,
public RTCIceCandidate(String sdpMid, int sdpMLineIndex, String candidate,
String serverUrl) {
this.sdpMid = sdpMid;
this.sdpMLineIndex = sdpMLineIndex;
this.sdp = sdp;
this.candidate = candidate;
this.serverUrl = serverUrl;
}

@Override
public String toString() {
return String.format("%s@%d [sdpMid=%s, sdpMLineIndex=%s, sdp=%s, serverUrl=%s]",
return String.format("%s@%d [sdpMid=%s, sdpMLineIndex=%s, candidate=%s, serverUrl=%s]",
RTCIceCandidate.class.getSimpleName(), hashCode(),
sdpMid, sdpMLineIndex, sdp, serverUrl);
sdpMid, sdpMLineIndex, candidate, serverUrl);
}
}