Update SDK version to 1.19.3#79
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the DevRev ADaaS TypeScript library used by the snap-in project, bringing in the latest dependency tree as captured in the lockfile.
Changes:
- Bump
@devrev/ts-adaasdependency from1.18.0to1.19.3. - Regenerate
package-lock.jsonto reflect updated transitive dependencies for the new SDK version.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
code/package.json |
Updates the pinned @devrev/ts-adaas version to 1.19.3. |
code/package-lock.json |
Updates resolved dependency graph to match the new SDK version and associated transitive upgrades. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "node_modules/@typescript-eslint/visitor-keys/node_modules/eslint-visitor-keys": { | ||
| "version": "4.2.1", | ||
| "resolved": "https://registry.npmjs.org/eslint-visitor-keys/-/eslint-visitor-keys-4.2.1.tgz", | ||
| "integrity": "sha512-Uhdk5sfqcee/9H/rCOJikYz67o0a2Tw2hGRPOG2Y1R2dg7brRe1uG0yaNQDHu+TO/uQPF/5eCapvYSmHUjt7JQ==", | ||
| "version": "5.0.1", | ||
| "resolved": "https://registry.npmjs.org/eslint-visitor-keys/-/eslint-visitor-keys-5.0.1.tgz", | ||
| "integrity": "sha512-tD40eHxA35h0PEIZNeIjkHoDR4YjjJp34biM0mDvplBe//mB+IHCqHDGV7pxF+7MklTvighcCPPZC7ynWyjdTA==", | ||
| "dev": true, | ||
| "license": "Apache-2.0", | ||
| "engines": { | ||
| "node": "^18.18.0 || ^20.9.0 || >=21.1.0" | ||
| "node": "^20.19.0 || ^22.13.0 || >=24" | ||
| }, |
There was a problem hiding this comment.
The lockfile now pulls in eslint-visitor-keys@5.0.1, which declares a Node engine requirement of ^20.19.0 || ^22.13.0 || >=24. Since package.json doesn’t declare an engines.node range (and dev deps still reference Node 18 types), this can make npm ci fail unexpectedly for contributors/environments on Node <20.19. Consider explicitly documenting/enforcing the minimum supported Node version (e.g., via package.json "engines" and/or an .nvmrc) or adjusting dependency versions to retain the previously supported Node range.
Description
Connected Issues
Checklist
npm run testOR no tests needed.npm run lint.