Skip to content

HNOCA fixes oregano#26

Open
aregano wants to merge 3 commits intodevsystemslab:mainfrom
aregano:main
Open

HNOCA fixes oregano#26
aregano wants to merge 3 commits intodevsystemslab:mainfrom
aregano:main

Conversation

@aregano
Copy link

@aregano aregano commented Nov 18, 2025

I tried to run HNOCA and it failed to initialize. Some simple fixes sorted it for me.

  1. Get rid of the check_deps() functions, as sometimes they fail to actually detect the packages they have been assigned (and besides the pipeline would fail regardless and the terminal will notify you which package is missing)
  2. fix wknn arguments allowing for gpu usage
  3. Change order of how the best score is found before the best label so the .max() function does not encounter a string that would throw an error

Furthermore there are some other fixes in the scpoly package that I have also modified so the mapping can work properly.

Thanks for providing us with these nice packages! I thought it was a pity that I could not get them work first for a few tiny issues :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments