Skip to content

simplify container dependencies in docker-compose in preparation for generating helm charts #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dray92 wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −4
Open

simplify container dependencies in docker-compose in preparation for generating helm charts #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ version: '3'
services:
db:
container_name: db
platform: linux/x86_64
image: mysql
hostname: backend-service-db
build:
Expand All @@ -20,7 +19,7 @@ services:
MYSQL_ALLOW_EMPTY_PASSWORD: "yes"
healthcheck:
test: mysql -h backend-service-db -P 3306 --user=$$MYSQL_USER --password=$$MYSQL_PASSWORD -e 'SHOW DATABASES;'
start_period: 10s
# start_period: 10s # change in docker-compose syntax support
Copy link
Contributor

@tylerackerson tylerackerson Oct 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this commented-out stuff?

interval: 2s
timeout: 5s
retries: 20
Expand All @@ -30,8 +29,7 @@ services:
dockerfile: backend-service/Dockerfile
hostname: backend-service
depends_on:
db:
condition: service_healthy
- db
ports:
- "9090:9090" # http
api:
Expand Down