Use HTTPS port for Ingress when enabled#100
Open
JoooostB wants to merge 4 commits intodexidp:masterfrom
Open
Conversation
Signed-off-by: Joost Buskermolen <joost@buskervezel.nl>
Signed-off-by: Joost Buskermolen <joost@buskervezel.nl>
nabokihms
requested changes
Dec 5, 2022
| {{- if .Values.ingress.enabled -}} | ||
| {{- $fullName := include "dex.fullname" . -}} | ||
| {{- $svcPort := .Values.service.ports.http.port -}} | ||
| {{- if .Values.https.enabled -}} |
Member
There was a problem hiding this comment.
I'd like to avoid forcing HTTPS there. Let's make it optional.
Author
There was a problem hiding this comment.
What method would you prefer to make this optional? Add an extra option to the Ingress object?
There was a problem hiding this comment.
@nabokihms Really would appreciate this being merged in, maybe some more information on whether we should add a flag to the ingress to use HTTPS port?
Member
There was a problem hiding this comment.
Sorry for the delay. Yes, I think an option for an ingress object will work.
Signed-off-by: Joost Buskermolen <joost@buskervezel.nl>
Signed-off-by: Joost Buskermolen <joost@buskervezel.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
When enabling HTTPS, the ingress still forwards traffic to the service over HTTP. This PR sets the destination port to the HTTPS port when
.Values.https.enabledis true.What this PR does / why we need it
Enabling HTTPS currently does nothing for the communication between the ingress and the service, defeating the purpose altogether. With this PR HTTPS is also used between the service and ingress (when complemented with the necessary annotation for nginx).
Special notes for your reviewer
Checklist
Chart.yaml(see the contributing guide for details)Chart.yaml(see the contributing guide for details)make docsSigned-off-by: Joost Buskermolen joost@buskervezel.nl