fix(charts/dex): update appProtocol for grpc service port#162
Open
aleicher wants to merge 2 commits intodexidp:masterfrom
Open
fix(charts/dex): update appProtocol for grpc service port#162aleicher wants to merge 2 commits intodexidp:masterfrom
aleicher wants to merge 2 commits intodexidp:masterfrom
Conversation
Signed-off-by: Andreas Leicher <email@andreasleicher.com>
Signed-off-by: Andreas Leicher <email@andreasleicher.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Sets the appProtocol in the kubernetes service on the GRPC port to
grpcto ensure the connection from other services, e.g. istio can use the proper protocolWhat this PR does / why we need it
Closes #147
Special notes for your reviewer
Checklist
Chart.yaml(see the contributing guide for details)Chart.yaml(see the contributing guide for details)make docs