add commonLabels, commonAnnotations, podLabels and podAnnotations#67
Open
ecthelion77 wants to merge 1 commit intodexidp:masterfrom
Open
add commonLabels, commonAnnotations, podLabels and podAnnotations#67ecthelion77 wants to merge 1 commit intodexidp:masterfrom
ecthelion77 wants to merge 1 commit intodexidp:masterfrom
Conversation
2 tasks
Signed-off-by: Olivier Gintrand <og@sylob.com>
ecthelion77
force-pushed
the
add-common
branch
from
0b3ad95 to
f3148c1
Compare
seblez
approved these changes
Nov 25, 2021
Author
|
/assign @sagikazarmark |
Member
|
Thanks for submitting a PR! To be honest, I'm not sure I understand why all this change is necessary to implement this feature.
I'd probably just modify the dex.labels template and create another one called dex.annotations. Even then, I'm not sure why this feature is necessary: most objects already support adding custom labels and annotations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
What this PR does / why we need it
Special notes for your reviewer
Checklist
Chart.yaml(see the contributing guide for details)Chart.yaml(see the contributing guide for details)make docs