Skip to content

Conversation

@deuchainn
Copy link

What the title says, when user enters as an spectator only they should not have hotkeys imo. since they are just viewing the ongoing game, just an thought if you disagree @Stx69 @cherryblue1024 just close this PR.

@Stx69
Copy link

Stx69 commented Apr 13, 2024

agree for spectate mode are hotkeys not needed. Should we only switch off default option for features?

@deuchainn
Copy link
Author

agree for spectate mode are hotkeys not needed. Should we only switch off default option for features?

Dunno, if we should switch off, when developing the default is that most settings are on but in production they are off.

Let's have a talk about what features we should have on/off, i think perhaps hotkeys could be off by default dunno? I think its a nice feature for super users that have played a couple of times.

@deuchainn
Copy link
Author

So i get what you meant now @Stx69, yeah perhaps we should just disable experimental features by default in prod?
Still i think my point is still valid for a spectator hotkeys will not make sense anyways, since they actually are not playing.

@cherryblue1024
Copy link

Many panes may be affected.

I agree that we can turn off the bottom hotkey in spectator mode first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants