Wip w4 #66
Open
Wip w4 #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mevernom
commented
Sep 23, 2024
mevernom
commented
- chore: add logos from round4 unions
- feat: displayName for players
fromddy
reviewed
Sep 24, 2024
| * @param newDisplayName - The new display name to set. | ||
| * @returns A transaction object for setting the display name. | ||
| */ | ||
| public async setDisplayName( |
There was a problem hiding this comment.
ContractsAPI only calls the contracts to get the data, not handle with the logic of submit transactions.
It is better to directly implement this function in GameManager
fromddy
reviewed
Sep 24, 2024
| public async setDisplayName( | ||
| playerAddress: EthAddress, | ||
| newDisplayName: string | ||
| ): Promise<Transaction<TxIntent>> { |
There was a problem hiding this comment.
please introduce UnconfirmedSetDisplayName
fromddy
reviewed
Sep 24, 2024
|
|
||
| // Function to set the displayName, accessible only by admin or player themselves | ||
| function setDisplayName(address player, string memory newDisplayName) public onlyAdminOrSelf(player) { | ||
| PlayerProfileStorage storage pps = LibStorage.playerProfileStorage(); |
There was a problem hiding this comment.
function pps() internal pure returns (PlayerProfileStorage storage) {
return LibStorage.playerProfileStorage();
}
You can directly use pps()
fromddy
reviewed
Sep 24, 2024
|
|
||
| // Function to get the displayName for a given player | ||
| function getDisplayName(address player) public view returns (string memory) { | ||
| PlayerProfileStorage storage pps = LibStorage.playerProfileStorage(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.