Fix SPM plugins failing when package path contains spaces #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URL.path() defaults to percentEncoded: true, which converts spaces to %20. This causes FileManager.fileExists, chmod, and CLI argument passing to fail when any path component contains spaces. Changed all .path() calls in plugin code to .path(percentEncoded: false). https://claude.ai/code/session_019ZDtwgBVq34rEkrVfQG94u
This serves as a CI regression test for the .path(percentEncoded:) fix — if paths with spaces break again, this CI job will fail. https://claude.ai/code/session_019ZDtwgBVq34rEkrVfQG94u
The link checker resolves %20 literally against the filesystem. Angle bracket syntax (<path with spaces>) lets markdown handle the spaces correctly while keeping the actual path on disk. https://claude.ai/code/session_019ZDtwgBVq34rEkrVfQG94u
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #193 +/- ##
=======================================
Coverage 99.90% 99.90%
=======================================
Files 32 32
Lines 3264 3264
=======================================
Hits 3261 3261
Misses 3 3
🚀 New features to boost your workflow:
|
Without quotes, users who copy the suggested command get a broken invocation when their package path contains spaces. https://claude.ai/code/session_019ZDtwgBVq34rEkrVfQG94u
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL.path() defaults to percentEncoded: true, which converts spaces to
%20. This causes FileManager.fileExists, chmod, and CLI argument passing
to fail when any path component contains spaces. Changed all .path()
calls in plugin code to .path(percentEncoded: false).
https://claude.ai/code/session_019ZDtwgBVq34rEkrVfQG94u