feat: add ic-canister-runtime crate
#35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpahlavi
changed the title
canruntime crateic-canister-runtime crate
lpahlavi
force-pushed
the
lpahlavi/create-runtime-crate
branch
from
4fa36b1 to
9824002
Compare
lpahlavi
force-pushed
the
lpahlavi/create-runtime-crate
branch
from
9824002 to
022551c
Compare
gregorydemay
reviewed
Nov 5, 2025
Collaborator
gregorydemay
left a comment
gregorydemay
left a comment
There was a problem hiding this comment.
Thanks for this PR @lpahlavi ! Some minor comments.
ic-canister-runtime/src/lib.rs
Outdated
|
|
||
| /// Runtime when interacting with a canister running on the Internet Computer. | ||
| #[derive(Copy, Clone, Eq, PartialEq, Debug)] | ||
| pub struct IcRuntime; |
Collaborator
There was a problem hiding this comment.
To reduce the risk of breaking change, let's ensure that this runtime can only be instantiated by a constructor (new() + Default). I could envision that in the future we sometimes don't always want to use unbounded_wait.
Contributor
Author
There was a problem hiding this comment.
Good idea! I added an unused private field to make sure it can only be instantiated with new or default now.
Contributor
Author
|
Thanks a lot for the feedback @gregorydemay! Your comments have been addressed. |
gregorydemay
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ic-canister-runtimecrate whoseRuntimetrait abstracts the canister runtime and allows code making calls to canister to be re-used:ic_cdk,PocketIc.