Skip to content

feat: add AgentRuntime #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: add AgentRuntime #36

wants to merge 4 commits into from

Conversation

@lpahlavi
Copy link
Contributor

@lpahlavi lpahlavi commented Nov 5, 2025 •
edited
Loading

Add a Runtime implementation making canister calls with ic-agent.

@lpahlavi lpahlavi changed the base branch from main to lpahlavi/create-runtime-crate November 5, 2025 09:21
@lpahlavi lpahlavi force-pushed the lpahlavi/agent-and-wallet-runtimes branch from 96ca4df to fcbc092 Compare November 5, 2025 13:33
@lpahlavi lpahlavi changed the title feat: add AgentRuntime and CyclesWalletRuntime feat: add AgentRuntime Nov 5, 2025
@lpahlavi lpahlavi changed the base branch from lpahlavi/create-runtime-crate to lpahlavi/wallet-runtime November 5, 2025 13:34
@lpahlavi lpahlavi force-pushed the lpahlavi/wallet-runtime branch from 37efc56 to 2e25bf6 Compare November 5, 2025 13:37
@lpahlavi lpahlavi force-pushed the lpahlavi/agent-and-wallet-runtimes branch from fcbc092 to d2b0beb Compare November 5, 2025 13:40
@lpahlavi lpahlavi force-pushed the lpahlavi/wallet-runtime branch from 2e25bf6 to 08a795d Compare November 6, 2025 09:31
@lpahlavi lpahlavi force-pushed the lpahlavi/agent-and-wallet-runtimes branch 2 times, most recently from e9de60e to a4a9cce Compare November 6, 2025 09:41
Base automatically changed from lpahlavi/wallet-runtime to main November 6, 2025 13:13
@lpahlavi lpahlavi force-pushed the lpahlavi/agent-and-wallet-runtimes branch from a4a9cce to 301c841 Compare November 6, 2025 15:12
@lpahlavi
Copy link
Contributor Author

lpahlavi commented Nov 6, 2025

@gregorydemay This runtime will be used in end-to-end tests to send requests to canisters deployed on the IC (see e.g. the SOL RPC canister e2e tests here). I guess there is also a risk of accidentally adding a dependency on ic-agent to the canister code though due to Cargo feature unification, and I could create a standalone crate instead. WDYT?

@lpahlavi lpahlavi requested a review from gregorydemay November 6, 2025 15:16
@lpahlavi lpahlavi marked this pull request as ready for review November 6, 2025 15:16
@lpahlavi lpahlavi requested a review from a team as a code owner November 6, 2025 15:16
@gregorydemay
Copy link
Collaborator

gregorydemay commented Nov 7, 2025

@lpahlavi: Yes I think I would prefer to have it in a separate crate. ic-canister-runtime should be as lean as possible. Even though we would use this implementation with agent for tests, it doesn't have to be the case so I would also not pack it with the mock crate, but rather have a dedicated small crate for it. Does it make sense?

@gregorydemay This runtime will be used in end-to-end tests to send requests to canisters deployed on the IC (see e.g. the SOL RPC canister e2e tests here). I guess there is also a risk of accidentally adding a dependency on ic-agent to the canister code though due to Cargo feature unification, and I could create a standalone crate instead. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gregorydemay gregorydemay Awaiting requested review from gregorydemay

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lpahlavi @gregorydemay