test: rejoin_test_long_rounds causes more expensive canister state cloning#10040
Merged
test: rejoin_test_long_rounds causes more expensive canister state cloning#10040
Conversation
alin-at-dfinity
approved these changes
Apr 28, 2026
Contributor
alin-at-dfinity
left a comment
alin-at-dfinity
left a comment
There was a problem hiding this comment.
LGTM, thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
rejoin_test_long_roundsto cause more expensive canister state cloning. The motivation for this change is that cloning many (100,000) canisters whose state does not change is cheap now that their canister state is wrapped in anArc. Hence, the updated test cycles through all those many canisters and keeps bumping their freezing threshold so that their canister state under anArcmust actually be cloned. The cyclic iteration is a busy computation and thus the original busy canisters with expensive heartbeats could be dropped now.