feat(ledgers): FI-1659: fix the generic ICRC-21 message, add FieldsDisplay#5563
feat(ledgers): FI-1659: fix the generic ICRC-21 message, add FieldsDisplay#5563maciejdfinity merged 37 commits intomasterfrom
Conversation
maciejdfinity
changed the title
maciejdfinity
added
the
CI_OVERRIDE_DIDC_CHECK
|
@maciejdfinity @mbjorkqvist don't merge this yet. We encountered a UX issue with Ledger using this format. I'm expecting to have a call with the agency developing the application to better understand the problem and possible solutions. This means that the format might change. |
@lmuntaner any news? |
Yes, we have a confirmation of the new format. The PR to change the standard is here: dfinity/wg-identity-authentication#241 Can you work with that? |
|
@lmuntaner @sea-snake I updated the PR according to changes in dfinity/wg-identity-authentication#241 and dfinity/wg-identity-authentication#243 in this commit: eff5050 IIUC the changes to use |
lmuntaner
left a comment
lmuntaner
left a comment
There was a problem hiding this comment.
Thanks @maciejdfinity !
I added a couple of comments, but yes, it looks good to me.
|
@maciejdfinity do yuo have ledger canisters in mainnet where we could deploy this and test it with the hardware wallet? |
@lmuntaner we have a TESTICP ledger in Orbit, I could deploy it there: https://dashboard.internetcomputer.org/canister/xafvr-biaaa-aaaai-aql5q-cai Would that work? edit: I deployed the changes from this PR to the above canister |
Thanks! I tested it and it works nicely!
|
…splay (#5563) Fix the generic ICRC-21 message returned by the ledgers to conform to https://github.com/dfinity/wg-identity-authentication/tree/main/topics/ICRC-21/examples, add `FieldsDisplay` and remove `LineDisplay`. CI_OVERRIDE_DIDC_CHECK: the removed `LineDisplay` shouldn't be used by any clients - it was meant for the Ledger hardware wallet which did not use it in the end either. --------- Co-authored-by: Maciej Dfinity <maciej@dfinity.org>
…splay (#5563) Fix the generic ICRC-21 message returned by the ledgers to conform to https://github.com/dfinity/wg-identity-authentication/tree/main/topics/ICRC-21/examples, add `FieldsDisplay` and remove `LineDisplay`. CI_OVERRIDE_DIDC_CHECK: the removed `LineDisplay` shouldn't be used by any clients - it was meant for the Ledger hardware wallet which did not use it in the end either. --------- Co-authored-by: Maciej Dfinity <maciej@dfinity.org>
4 participants
Fix the generic ICRC-21 message returned by the ledgers to conform to https://github.com/dfinity/wg-identity-authentication/tree/main/topics/ICRC-21/examples, add
FieldsDisplayand removeLineDisplay.CI_OVERRIDE_DIDC_CHECK: the removed
LineDisplayshouldn't be used by any clients - it was meant for the Ledger hardware wallet which did not use it in the end either.