perf(crypto): CRP-2550 Enable Rayon in NIDKG again#9987
Open
perf(crypto): CRP-2550 Enable Rayon in NIDKG again#9987
Conversation
There are too many tests that want to concurrently start N IC instances all at once so having a thread pool per vault doesn't work
Contributor
Author
|
The general flavor of the test flakes seem to be a number of test binaries want to concurrently spawn up 8-20 IC instances running in the same process (probably already at the limits of flaking IMO) then when we add a few more threads to each IC instance everything falls over. 33155e3 attempts to reduce this by sharing the NIDKG pool but likely as not that's simply causing starvation where one of the test ICs claims the entire pool and then some other IC times out waiting for progress to be made. Likely fixing this (and/or being able to make use of any parallelism in crypto) will require breaking apart (or serializing) these big tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally added in #9007 reverted in #9968