feat(agent): allow passing identity into all HttpAgent canister requests#1286
Open
hpeebles wants to merge 14 commits intodfinity:mainfrom
Open
feat(agent): allow passing identity into all HttpAgent canister requests#1286hpeebles wants to merge 14 commits intodfinity:mainfrom
HttpAgent canister requests#1286hpeebles wants to merge 14 commits intodfinity:mainfrom
Conversation
hpeebles
changed the title
pollForResponsepollForResponse
hpeebles
changed the title
pollForResponsepollForResponse
hpeebles
changed the title
pollForResponsepollForResponse
hpeebles
changed the title
pollForResponseHttpAgent canister requests
hpeebles
commented
Mar 25, 2026
| requestId = getRequestId(fields); | ||
|
|
||
| // Always create a fresh request with the current identity | ||
| const identity = await this.#identity; |
Contributor
Author
There was a problem hiding this comment.
We don't need to calculate the identity here since that already happens within createReadStateRequest
hpeebles
commented
Mar 25, 2026
| * @see https://internetcomputer.org/docs/current/references/ic-interface-spec/#http-effective-canister-id | ||
| */ | ||
| effectiveCanisterId: Principal | string; | ||
| effectiveCanisterId?: Principal | string; |
Contributor
Author
There was a problem hiding this comment.
I made this optional to be consistent with QueryFields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
You can already specify the identity when using
call,queryandreadState, but this option was not exposed bypollForResponse. This PR simply bringspollForResponsein line with the other similar functions.By setting the identity with each request we are able to construct a single
HttpAgentinstance when the app starts, and can continue to use it after the user signs in / out by simply passing in the updated identity.How Has This Been Tested?
I have used this new functionality locally within an app I'm building.
Checklist: