feat: add optional onPollingStarted callback when making update calls#1345
Merged
nikosxenakis merged 13 commits intodfinity:mainfrom Apr 23, 2026
Merged
feat: add optional onPollingStarted callback when making update calls#1345nikosxenakis merged 13 commits intodfinity:mainfrom
onPollingStarted callback when making update calls#1345nikosxenakis merged 13 commits intodfinity:mainfrom
Conversation
raymondk
reviewed
Apr 10, 2026
hpeebles
changed the title
onRequestAccepted callback when making update callsonPollingStarted callback when making update calls
nikosxenakis
previously approved these changes
Apr 23, 2026
Contributor
nikosxenakis
left a comment
nikosxenakis
left a comment
There was a problem hiding this comment.
Looks good, thank you.
Contributor
|
@hpeebles please resolve the conflict and I can merge the changes. |
github-actions
Bot
dismissed
nikosxenakis’s stale review
Review dismissed by automation script.
nikosxenakis
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This allows devs to specify an optional callback when submitting update calls, which will be invoked once their request has been accepted by the IC.
We use this within OpenChat to display the first message tick, signalling that the message has made its way to the backend.
How Has This Been Tested?
I have added tests which cover the various cases where the callback should either be invoked or not, and also we are using this successfully within OpenChat.
Checklist: