Skip to content

fix: use correct locktime and version in Taproot sighash#18

Merged
fspreiss merged 4 commits intomainfrom
issue-14
Apr 17, 2026
Merged

fix: use correct locktime and version in Taproot sighash#18
fspreiss merged 4 commits intomainfrom
issue-14

Conversation

@fspreiss
Copy link
Copy Markdown
Contributor

Fixes #14

@fspreiss fspreiss marked this pull request as ready for review April 16, 2026 06:48
@fspreiss fspreiss requested a review from a team as a code owner April 16, 2026 06:48
@fspreiss fspreiss requested a review from randombit April 16, 2026 06:52
Comment thread src/bitcoin/Transaction.mo Outdated
Copy link
Copy Markdown
Contributor

@timohanke timohanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small comment (code cosmetic).

Copy link
Copy Markdown

@randombit randombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fspreiss fspreiss merged commit 57501d4 into main Apr 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Potential issue with locktime being ignored

3 participants