chore(backend): remove get_proposal_payload canister endpoint#7752
Merged
chore(backend): remove get_proposal_payload canister endpoint#7752
Conversation
yhabib
force-pushed
the
nns1-4334/clean-up
branch
from
d6729ed to
830d7e6
Compare
0xFFrancesco
approved these changes
Feb 27, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 7, 2026
…7753) # Motivation Follow-up to #7752. The `get_proposal_payload` backend endpoint is gone, so the `proposals` crate is now unused. Cleaning up the crate and all the surrounding infrastructure (CI workflows, scripts, declarations). # Changes - Removed the `rs/proposals/` crate and its workspace entry. - Removed workspace dependencies only used by proposals (`dfn_core`, `ic-nervous-system-root`, `ic-protobuf`, `registry-canister`). - Removed `scripts/proposals/` (codegen scripts) and `declarations/used_by_proposals/` (fetched candid files). - Removed `.github/workflows/update-proposals.yml` and the proposals codegen step from `checks.yml`. - Removed `scripts/dfx-nns-proposal-args` and its test (CI job was already disabled). - Removed `IC_COMMIT_FOR_PROPOSALS` from `config.json` and proposals references from `Dockerfile`, `scripts/update_ic_commit`, and `BOT_APPROVED_FILES`. - Moved `nns_governance.did` to `declarations/nns_governance/` and updated `dfx.json` (still needed for local dev scripts).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The frontend no longer calls
get_proposal_payloadafter switching toselfDescribingActionin #7742. This is the first step toward removing theproposalscrate entirely.Changes
get_proposal_payloadupdate endpoint from the backend canister.proposalscrate dependency from the backendCargo.toml.GetProposalPayloadResponsetype andget_proposal_payloadmethod from the Candid interface (backend and frontend copies).get_proposal_payloadentry from canister export lists (production and test).test-proposal-payloadscript and its CI step in the build workflow.