Skip to content

allow for more base kernel reuse #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrus merged 1 commit into from
Oct 11, 2025
Merged

allow for more base kernel reuse #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions jjava-jupyter/src/main/java/org/dflib/jjava/jupyter/kernel/BaseKernel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ protected void replaceOutputStreams(ShellReplyEnvironment env) {
});
}

private synchronized void handleExecuteRequest(ShellReplyEnvironment env, Message<ExecuteRequest> executeRequestMessage) {
protected synchronized void handleExecuteRequest(ShellReplyEnvironment env, Message<ExecuteRequest> executeRequestMessage) {
commManager.setMessageContext(executeRequestMessage);

ExecuteRequest request = executeRequestMessage.getContent();
Expand Down Expand Up @@ -398,7 +398,7 @@ private synchronized void handleExecuteRequest(ShellReplyEnvironment env, Messag
}
}

private void handleInspectRequest(ShellReplyEnvironment env, Message<InspectRequest> inspectRequestMessage) {
protected void handleInspectRequest(ShellReplyEnvironment env, Message<InspectRequest> inspectRequestMessage) {
InspectRequest request = inspectRequestMessage.getContent();
env.setBusyDeferIdle();
try {
Expand All @@ -409,7 +409,7 @@ private void handleInspectRequest(ShellReplyEnvironment env, Message<InspectRequ
}
}

private void handleCompleteRequest(ShellReplyEnvironment env, Message<CompleteRequest> completeRequestMessage) {
protected void handleCompleteRequest(ShellReplyEnvironment env, Message<CompleteRequest> completeRequestMessage) {
CompleteRequest request = completeRequestMessage.getContent();
env.setBusyDeferIdle();
try {
Expand All @@ -423,7 +423,7 @@ private void handleCompleteRequest(ShellReplyEnvironment env, Message<CompleteRe
}
}

private void handleHistoryRequest(ShellReplyEnvironment env, Message<HistoryRequest> historyRequestMessage) {
protected void handleHistoryRequest(ShellReplyEnvironment env, Message<HistoryRequest> historyRequestMessage) {
// If the manager is unset, short circuit and skip this message
HistoryManager manager = this.getHistoryManager();
if (manager == null) {
Expand Down Expand Up @@ -459,7 +459,7 @@ private void handleHistoryRequest(ShellReplyEnvironment env, Message<HistoryRequ
}
}

private void handleIsCodeCompeteRequest(ShellReplyEnvironment env, Message<IsCompleteRequest> isCompleteRequestMessage) {
protected void handleIsCodeCompeteRequest(ShellReplyEnvironment env, Message<IsCompleteRequest> isCompleteRequestMessage) {
IsCompleteRequest request = isCompleteRequestMessage.getContent();
env.setBusyDeferIdle();

Expand All @@ -483,7 +483,7 @@ private void handleIsCodeCompeteRequest(ShellReplyEnvironment env, Message<IsCom
env.reply(reply);
}

private void handleKernelInfoRequest(ShellReplyEnvironment env, Message<KernelInfoRequest> kernelInfoRequestMessage) {
protected void handleKernelInfoRequest(ShellReplyEnvironment env, Message<KernelInfoRequest> kernelInfoRequestMessage) {
env.setBusyDeferIdle();
env.reply(new KernelInfoReply(
Header.PROTOCOL_VERISON,
Expand All @@ -496,7 +496,7 @@ private void handleKernelInfoRequest(ShellReplyEnvironment env, Message<KernelIn
);
}

private void handleShutdownRequest(ShellReplyEnvironment env, Message<ShutdownRequest> shutdownRequestMessage) {
protected void handleShutdownRequest(ShellReplyEnvironment env, Message<ShutdownRequest> shutdownRequestMessage) {
ShutdownRequest request = shutdownRequestMessage.getContent();
env.setBusyDeferIdle();

Expand All @@ -509,7 +509,7 @@ private void handleShutdownRequest(ShellReplyEnvironment env, Message<ShutdownRe
env.markForShutdown();
}

private void handleInterruptRequest(ShellReplyEnvironment env, Message<InterruptRequest> interruptRequestMessage) {
protected void handleInterruptRequest(ShellReplyEnvironment env, Message<InterruptRequest> interruptRequestMessage) {
env.setBusyDeferIdle();
env.defer().reply(new InterruptReply());

Expand Down
2 changes: 1 addition & 1 deletion jjava-jupyter/src/main/java/org/dflib/jjava/jupyter/kernel/display/Renderer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ public <T> void register(Set<MIMEType> supported, Set<MIMEType> preferred, Set<C
}));
}

private static DisplayData finalizeDisplayData(DisplayData data, Object value) {
protected DisplayData finalizeDisplayData(DisplayData data, Object value) {
if (!data.hasDataForType(MIMEType.TEXT_PLAIN))
data.putText(String.valueOf(value));

Expand Down