Open
Conversation
xorgy
approved these changes
Mar 29, 2025
Collaborator
If somebody is willing to do the work, anything in Swash that has an equivalent in Skrifa should be replaced with that equivalent. Swash was the proving ground for significant parts of Skrifa, but Skrifa should be considered to supersede Swash's versions of these things. |
Collaborator
|
I noticed you have a |
Collaborator
|
@dfrg Thoughts on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like with googlefonts/fontations#497, we were previously not falling back to phantom point deltas if the
hvartable was missing. This implements that.I've used skrifa/read_fonts for this since it was already being used for
adjust_axisand means we don't have to reimplement all the parsing here. This does require transmuting thecoordsfrom&[i16]to&[F2Dot14], but there are some transmutes like that already in the codebase (e.g. insrc/text/compose.rs).(Speaking of, which parts of this library are you planning to replace with skrifa?)