Conversation
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
nicoburns
changed the title
skrifa::OutlinePen implementation privateskrifa::OutlinePen impl private
xStrom
approved these changes
May 8, 2025
Collaborator
xStrom
left a comment
xStrom
left a comment
There was a problem hiding this comment.
This seems like a good idea to me.
I also confirmed that Cosmic Text still builds nicely with these changes.
Owner
|
awesome, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been treating as private by doing technically breaking releases that change the
skrifaversion of this trait impl, so better to make the impl private.I've also included a couple of minor code changes aimed at making easier to verify that
skrifais indeed a private dependency by reducing the scope in which types are available.