Add return type dataclassreader #57
Merged
+14
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make DataclassReader a Generic class whose type is defined by the type of dataclass supplied to the init function
kraktus
added a commit
to kraktus/dataclass-csv2
that referenced
this pull request
Jan 25, 2025
|
I released an updated version (with up-to-date tooling) of the lib which includes this fix a dataclass-csv2 on pypi, (repo). Hopefully if/when the maintainer become active again I could merge back to upstream. |
dfurtado
approved these changes
Nov 17, 2025
Owner
|
Thank you so much @danjjackson Sorry for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #56
Makes DataclassReader a generic class, which returns objects of that type