Skip to content

🎨 Palette: Improve loading experience and accessibility #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dgalodesign wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🎨 Palette: Improve loading experience and accessibility #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
## 2025-05-14 - Loading Experience and Accessibility Improvements

**Learning:** Providing a matching `background-color` on the parent container of an iframe prevents a "white flash" during loading, especially in dark-themed applications. Setting the correct `lang` attribute and descriptive `title` for iframes is crucial for screen reader accessibility.

**Action:** Always check for dark theme background colors and apply them to the root document when wrapping external content in an iframe. Ensure semantic HTML attributes like `lang` match the primary content language.
18 changes: 3 additions & 15 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,12 @@
<!DOCTYPE html>
<html lang="en">
<html lang="es">

<head>
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Edgar D' Galo • UX/UI Designer | Portafolio Online</title>
<style>
body {
margin: 0;
padding: 0;
overflow: hidden;
}

iframe {
width: 100vw;
height: 100vh;
border-width: 0;
}
</style>
<link rel="stylesheet" href="style.css">
<!-- Google tag (gtag.js) -->
<script async src="https://www.googletagmanager.com/gtag/js?id=G-ZJBEJJF727"></script>
<script>
Expand All @@ -31,7 +19,7 @@
</head>

<body>
<iframe style.super-badge="display: none" src="https://dgalodesign.super.site"></iframe>
<iframe title="Portafolio de Edgar D' Galo" src="https://dgalodesign.super.site"></iframe>
</body>

</html>
2 changes: 2 additions & 0 deletions style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
html,
body {
margin: 0;
padding: 0;
overflow: hidden;
background-color: hsl(220, 13%, 18%);
}

iframe {
Expand Down