Skip to content

🎨 Palette: Improve accessibility and loading experience #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dgalodesign wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🎨 Palette: Improve accessibility and loading experience #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
## UX/Accessibility Learnings - Portfolio

- The site is a wrapper for a Super.site portfolio. To avoid a "white flash" during loading, the parent page background should match the portfolio's dark theme.
- The `iframe` must have a `title` attribute for accessibility.
- The `html` `lang` attribute should reflect the primary content language (Spanish).
- Maintain global styles in `style.css` instead of internal `<style>` blocks for better maintenance.
18 changes: 3 additions & 15 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,12 @@
<!DOCTYPE html>
<html lang="en">
<html lang="es">

<head>
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Edgar D' Galo • UX/UI Designer | Portafolio Online</title>
<style>
body {
margin: 0;
padding: 0;
overflow: hidden;
}

iframe {
width: 100vw;
height: 100vh;
border-width: 0;
}
</style>
<link rel="stylesheet" href="style.css">
<!-- Google tag (gtag.js) -->
<script async src="https://www.googletagmanager.com/gtag/js?id=G-ZJBEJJF727"></script>
<script>
Expand All @@ -31,7 +19,7 @@
</head>

<body>
<iframe style.super-badge="display: none" src="https://dgalodesign.super.site"></iframe>
<iframe title="Portafolio de Edgar D' Galo" style.super-badge="display: none" src="https://dgalodesign.super.site"></iframe>
</body>

</html>
1 change: 1 addition & 0 deletions style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ body {
margin: 0;
padding: 0;
overflow: hidden;
background-color: hsl(220, 13%, 18%);
}

iframe {
Expand Down