Open
Conversation
2d427bb to
fb129f7
Compare
This would be very useful to create custom reports, where we can trigger actions as well.
fb129f7 to
8fcd43f
Compare
JMX set attribute PoC
RASBORA
reviewed
Mar 22, 2021
| this method return the json serialization of this object | ||
| :return: json string | ||
| """ | ||
| json_param = ",".join(["{\"value\":\""+param.value+"\", type:\""+param.value_type+"\"}" for param in self.params]) |
There was a problem hiding this comment.
This JSON is incorrect that occurred an error in Java.
Suggested change
| json_param = ",".join(["{\"value\":\""+param.value+"\", type:\""+param.value_type+"\"}" for param in self.params]) | |
| json_param = ",".join(["{\"value\":\""+param.value+"\"," type":\""+param.value_type+"\"}" for param in self.params]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the JMXQuery library to let the user invoke JMX methods. This would be very useful to create custom reports, where we can trigger actions as well.