Skip to content

Conversation

@minhaj-shakeel
Copy link

Fixes GRAPHQL-671.

This PR adds argument validation in the directive validation applied to the fields inside a given type.
For example earlier

type T { 
  dummyField: String! @search(xyz: [hash])
}

didn't return error while validation of type but now it does.

@pawanrawal pawanrawal force-pushed the master branch 2 times, most recently from 59e59a8 to 6b4a785 Compare November 3, 2020 07:19
@StevenACoffman
Copy link

@minhaj-shakeel Hi! I've started maintaining vektah/gqlparser and I would love to merge your improvements upstream. I know you are all dealing with quite a bit, but if I can help in any way, please don't hesitate to let me know.

@StevenACoffman
Copy link

Hello again! I would love to help merge the improvements in this fork into the upstream version. I would really appreciate it if you can open PRs there if you get a chance. I made a draft mega-giant-one just to remember what all the DGraph changes were: vektah#179

People who contributed to that are:
@pawanrawal @JatinDev543 @harshil-goel @anurags92 @NamanJain8

@CLAassistant
Copy link

CLAassistant commented Apr 29, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ harshil-goel
❌ minhaj-shakeel
❌ ahsanbarkati
You have signed the CLA already but the status is still pending? Let us recheck it.

@cscetbon
Copy link

hey, is that PR dead ?

@StevenACoffman
Copy link

Hey, @ryanfoxtyler I took a look but wasn't familiar enough with the dgraph codebase to get it to use the upstream gqlparser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

8 participants