Audit Fixes (Merged) #56
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tests - Added error for in-kind withdrawals during liquidation in IOffice.sol. - Updated CollateralLiquidationParams struct to include inKind boolean. - Modified liquidation logic in CommonFunctions to handle in-kind withdrawals when liquidity is insufficient. - Adjusted tests in Office_liquidate to cover scenarios for in-kind liquidation, including partial and complete liquidations with bad debt. - Updated expected asset repayment calculations to account for liquidation bonuses. - Enhanced test coverage for various liquidation scenarios, ensuring correct behavior when liquidity is insufficient.
…d contracts - Refactor liquidation bonus percentage handling in SimpleMarketConfig to support per-collateral and debt asset relationships. - Modify IMarketConfig interface to include parameters for account, collateral and debt asset in liquidation bonus calculation. - Update Office contract to utilize new liquidation bonus logic during liquidation processes. - Enhance test cases in Office_liquidate to validate new liquidation bonus calculations and ensure correct asset repayments. - Remove deprecated liquidation bonus percentage parameter from market creation and migration functions.
- Only allows approvals to a user account (basically addresses). - Anyone can invoke this function on behalf of an account but the allowance will only be considered based on the owner of the account. The allowances set by non-owners will be active if/when they own the account.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Refactored tests for Registry_transferFrom to clarify allowance behavior and error handling - Updated test descriptions to specify that allowance amounts should not change when transferring tokens. - Clarified expected outcomes for various scenarios, including transfers with zero amounts and insufficient balances. - Ensured consistency in error messages related to insufficient balance and allowance. - Enhanced readability and maintainability of test cases by organizing them logically.
… when assets are seized
…face documentation
…alidation in migrateSupply function
…sive leverage on same asset pairs
…egarding delegation call behavior and transient storage implications
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Interest Accrual related fixes [Additional Fixes]
Simple Weights [Additional Fixes]
…512-bit multiplication.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…gator `_getQuote` overflow audit issue fix
…teral and liquidate functions for execution control
rashtrakoff
force-pushed
the
audit-fixes/all-merged
branch
from
cb6b1af to
abb39ec
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Allow setting operators by non-account owners.
Recipient min debt amount check added
Fix dust amount liquidation issues
Hook call placement refactor
…check-fix Check that caller is delegatee during `transferFrom` call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges all of the fixed audit issues.