Skip to content

feat(offline): keep pings active while focus is in iframes #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
KaiVandivier wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat(offline): keep pings active while focus is in iframes #1411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions services/offline/src/lib/dhis2-connection-status/dhis2-connection-status.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,16 @@ export const Dhis2ConnectionStatusProvider = ({
})
smartIntervalRef.current = smartInterval

const handleBlur = () => smartInterval.pause()
const handleFocus = () => smartInterval.resume()
// Use visibility change instead of focus/blur to continue while focus
// might be in iframes
const handleVisibilityChange = () => {
if (document.visibilityState === 'hidden') {
smartInterval.pause()
} else {
// visibilityState === 'visible'
smartInterval.resume()
}
}
// Pinging when going offline should be low/no-cost in both online and
// local servers
const handleOffline = () => smartInterval.invokeCallbackImmediately()
Expand All @@ -163,14 +171,15 @@ export const Dhis2ConnectionStatusProvider = ({
15000
)

window.addEventListener('blur', handleBlur)
window.addEventListener('focus', handleFocus)
document.addEventListener('visibilitychange', handleVisibilityChange)
window.addEventListener('offline', handleOffline)
window.addEventListener('online', handleOnline)

return () => {
window.removeEventListener('blur', handleBlur)
window.removeEventListener('focus', handleFocus)
document.removeEventListener(
'visibilitychange',
handleVisibilityChange
)
window.removeEventListener('offline', handleOffline)
window.removeEventListener('online', handleOnline)

Expand Down
Loading