Skip to content

Don't try connect_telnet on Windows when '-p' is specified#233

Open
github0null wants to merge 1 commit intodhylands:masterfrom
github0null:master
Open

Don't try connect_telnet on Windows when '-p' is specified#233
github0null wants to merge 1 commit intodhylands:masterfrom
github0null:master

Conversation

@github0null
Copy link
Copy Markdown

Hello,

I noticed this case can't work on Windows, because windows serial port name usually is: 'COMxx', not include '/'

rshell/rshell/main.py

Lines 1420 to 1427 in 56f75cf

def connect(port, baud=115200, user='micro', password='python', wait=0):
"""Tries to connect automagically via network or serial."""
if '/' in port:
connect_serial(port, baud=baud, wait=wait)
else:
try:
ip_address = socket.gethostbyname(port)
#print('Connecting to ip', ip_address)

So it always try connect_telnet and elapse more time.

#202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant