feat(icon): DLT-3136 convert docs inline svgs to components#1123
Merged
Josh Everhart (jeverhart-dialpad) merged 2 commits intostagingfrom Mar 13, 2026
Merged
Conversation
Contributor
|
Please add either the |
Contributor
|
✔️ Deploy previews ready! |
Josh Everhart (jeverhart-dialpad)
added
the
visual-test-ready
Contributor
Author
|
🗒️ Percy flagged changes on the storybook icon variants page (https://dialtone.dialpad.com/vue/deploy-previews/pr-1123/?path=/story/components-icon--variants) 
These are expected, as the codepen icon would now show in that flagged area, causing the shift. |
Francis Rupert (francisrupert)
approved these changes
Mar 13, 2026
Contributor
Francis Rupert (francisrupert)
left a comment
Francis Rupert (francisrupert)
left a comment
There was a problem hiding this comment.
Nice call. Merge this right off your plate.
Brad Paugh (braddialpad)
approved these changes
Mar 13, 2026
Josh Everhart (jeverhart-dialpad)
deleted the
DLT-3136-convert-svgs-to-components
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(icon): DLT-3136 convert docs inline svgs to components
Obligatory GIF (super important!)
🛠️ Type Of Change
These types will increment the version number on release:
These types will not increment the version number, but will still deploy to documentation site on release:
📖 Jira Ticket
https://dialpad.atlassian.net/browse/DLT-3136
📖 Description
Move inline SVG icons that appear in the documentation site into the dialtone icons package so they can more easily be re-used. These include Storybook (color & mono), Github, Codepen, and Figma.
Currently used in the top nav bar, page headers for components, and a popover displayed in the brand page.
💡 Context
The Dialtone docs site uses a series of brand icons in the top navigation and also in inner page headers. Those icons are currently inline SVGs.
📝 Checklist
For all PRs:
🔮 Next Steps
Update usage on the UI kits landing page in the
nextbranch (afterstagingis merged intonextin the future).📷 Screenshots / GIFs
🔗 Sources