ci: NO-JIRA add Claude AI code review workflows#1124
ci: NO-JIRA add Claude AI code review workflows#1124belumontoya wants to merge 2 commits intostagingfrom
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0d3c4dcdf9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "codex (@codex) address that feedback".
|
Why we have an automatic and a on-demand? it is because cost? Could we add something like what we have for visual changes? I mean, a message on the PR that if you want a Claude review just mention |
Ignacio Ropolo (iropolo)
left a comment
There was a problem hiding this comment.
Seems to be a good start
Yes, it only runs when someone tags Claude (@claude) in a comment. It does NOT run on every push. The if: condition checks for contains(github.event.comment.body, 'Claude (@claude)') on every trigger. The claude-code-review.yml runs automatically on PR open and ready-for-review only, not on synchronise (pushes), so it won't fire on every push either. Codex does the same thing running on PR open, and on tag codex (@codex) |
🛠️ Type Of Change
📖 Jira Ticket
N/A
📖 Description
Adds two GitHub Actions workflows for Claude AI-powered code reviews:
claude-code-review.yml— Automatic inline code review on every PR (open / ready-for-review). Also supports manual trigger viaworkflow_dispatch.claude.yml— On-demand@claudemention bot for PRs, issues, and review comments.💡 Context
Dialtone is a public design system consumed by all Dialpad products. Code review quality directly impacts downstream consumers. These workflows add an AI reviewer that enforces Dialtone-specific rules inline on the exact lines that need attention:
BREAKING CHANGE:footer)--dt-*tokens)Dtprefix, boolean prop naming, typed props)The
ANTHROPIC_API_KEYsecret has already been added to the repo.Reviews use the inline PR Review API — comments appear on the exact diff lines with severity levels (🔴 CRITICAL / 🟡 MAJOR / 🟢 MINOR). No summary comments.
📝 Checklist
🔮 Next Steps
stagingso the workflows exist on the base branch (required for GitHub Actionspull_requesttriggers)