operation.go: guard global mem from concurent writes on startup and config#124
Merged
diegoholiveira merged 1 commit intodiegoholiveira:mainfrom Jun 10, 2025
Merged
Conversation
…onfig Signed-off-by: Ohad Moisi <omoisi@akamai.com>
Moisi
force-pushed
the
safer_operations_map
branch
from
1ce07c1 to
cf2ad20
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
+ Coverage 97.05% 97.07% +0.01%
==========================================
Files 9 9
Lines 883 889 +6
==========================================
+ Hits 857 863 +6
Misses 17 17
Partials 9 9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
diegoholiveira
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On our project all unit-test must run with
Parallel()and with-raceflag enabled.Having
jsonlogicnot guarding a shared memory makes it hard for us to run unit-test and search for possible bugs.This PR introduces a mutex around writes to the operations map, helping race-detector relax a bit.
I'm happy to expand on this PR as required by the project guidelines.
Ohad