protect global map access with read lock#127
Merged
diegoholiveira merged 1 commit intodiegoholiveira:mainfrom Sep 16, 2025
Merged
protect global map access with read lock#127diegoholiveira merged 1 commit intodiegoholiveira:mainfrom
diegoholiveira merged 1 commit intodiegoholiveira:mainfrom
Conversation
If you call AddOperator() and either Apply() or IsValid() concurrently, the Go runtime can throw a fatal error about a concurrent map read+write. Similarly, tests that perform these operations concurrently will trigger race detector failures. Make the operators lock into an RWMutex and hold a read lock when accessing the map to avoid this race.
diegoholiveira
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you call AddOperator() and either Apply() or IsValid() concurrently, the Go runtime can throw a fatal error about a concurrent map read+write. Similarly, tests that perform these operations concurrently will trigger race detector failures.
Make the operators lock into an RWMutex and hold a read lock when accessing the map to avoid this race.